Conversation
|
cc @oandregal @gziolo if you could help me double check this |
|
I've compared the changes with core and it looks good. I'm trying to find the tests instructions in older PRs. |
|
This is what I've done for testing (updated from #306):
|
|
I've also run |
|
Awesome, thanks for testing! 🎉 Totally forgot that this is just the backup file. That makes the change way less urgent 🙂 I'll see if I can reproduce that test failure locally. |
We can add a GHA that replaces the included file with the one on SVN and creates a PR if changes have been detected. |
|
@schlessera Good idea. Just added such a workflow now. |
We really need a better way to keep this file in sync with core.Edit: forgot that we fetch directly from svn