Add ext-mbstring to list of suggested dependencies#263
Merged
schlessera merged 4 commits intomasterfrom Jul 5, 2021
Merged
Conversation
Member
|
I cannot merge this change, as it would effectively force this requirement for the entire bundled WP-CLI. Instead of adding a hard requirement to Composer, it should be a suggested optional dependency, and the command should have a |
Member
Author
Makes sense. Just made the necessary changes 👍 |
swissspidy
changed the title
ext-mbstring to list of required dependenciesext-mbstring to list of suggested dependencies
schlessera
requested changes
Jul 5, 2021
schlessera
approved these changes
Jul 5, 2021
swissspidy
commented
Jul 5, 2021
schlessera
added a commit
that referenced
this pull request
Jan 6, 2022
Add `ext-mbstring` to list of suggested dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IterableCodeExtractorusesmb_ereg.Fixes #138