Add option to list recently active plugins by thrijith · Pull Request #383 · wp-cli/extension-command

thrijith · 2023-11-13T07:47:41Z

Fixes #232

Add examples for activate and listing plugins with new flag Add tests for new flag

swissspidy · 2023-11-13T09:42:33Z

@wp-cli/committers Instead of wp plugin list --recently-active, should we just make this wp plugin list --status=recently-active?

danielbachhuber · 2023-11-13T10:45:29Z

Instead of wp plugin list --recently-active, should we just make this wp plugin list --status=recently-active?

@swissspidy I prefer --recently-active because recently_active is a separate column, not a value in the status column.

danielbachhuber · 2023-11-27T13:02:59Z

features/plugin-recently-active.feature

@@ -0,0 +1,103 @@
+Feature: List Recently Active WordPress plugins


Can we rename this file to plugin-list-recently-active.feature?

Also, given we have a code path for multisite, we should have a multisite scenario too.

Updated in 805760d

danielbachhuber · 2023-11-27T13:05:37Z

src/Plugin_Command.php

 			$auto_updates = [];
 		}

+		$recently_active = is_multisite() ? get_site_option( 'recently_activated' ) : get_option( 'recently_activated' );


Is this get_site_option( 'recently_activated' ) option applied to single site plugin pages on multisite too? Or only the network plugins screen?

yes,

extension-command/src/Plugin_Command.php

Lines 443 to 453 in 7118325

if ( ! is_network_admin() ) {

update_option(

'recently_activated',

array( $plugin->file => time() ) + (array) get_option( 'recently_activated' )

);

} else {

update_site_option(

'recently_activated',

array( $plugin->file => time() ) + (array) get_site_option( 'recently_activated' )

);

}

I've updated condition to match what I found in deactivate.

danielbachhuber · 2023-11-27T13:06:04Z

src/Plugin_Command.php

 	 * : If set, the plugin update check will be skipped.
 	 *
+	 * [--recently-active]
+	 * : If set, only recently active plugins will be shown and the status filter will be ignored.


We should document how the behavior changes for multisite too.

@danielbachhuber sorry, didn't get what needs to be done here.

danielbachhuber · 2023-11-27T13:06:57Z

src/WP_CLI/CommandWithUpgrade.php


 		$all_items = $this->get_all_items();

+		// Only show plugins that are recently active.


This comment isn't necessary and can be removed. It simply duplicates the code.

Removed in 805760d, but I didn't get what you meant here.

thrijith · 2023-12-03T15:11:31Z

Not sure what the error is in https://github.com/wp-cli/extension-command/actions/runs/7077555679/job/19262025024?pr=383#step:12:260, unable to replicate on local site, getting this error only in tests, please check https://cleanshot.thrijith.com/jMsCpCyk

danielbachhuber · 2023-12-08T22:23:54Z

@thrijith You can merge main to fix the unrelated broken tests. I fixed them up with #389.

I'd recommend setting up the Behat test suite locally so it's easier for you to debug the failure specific to your tests.

thrijith · 2024-03-01T13:31:14Z

Closing the PR as I was not able to figure out the reason for one of the failure in tests, anyone who wants to takes this, please feel free to do so, thanks!

Add option to list recently active plugins

e6164f6

Add examples for activate and listing plugins with new flag Add tests for new flag

thrijith requested a review from a team as a code owner November 13, 2023 07:47

thrijith added 5 commits November 13, 2023 13:20

Fix liniting issues

0512b73

Fix liniting issues

baf1b22

Change plugin to use in tests

5db1c39

Change plugin to use in tests

42cee3a

Update tests

c9f932d

swissspidy approved these changes Nov 26, 2023

View reviewed changes

danielbachhuber added command:plugin Related to 'plugin' command command:plugin-list Related to 'plugin list' command labels Nov 27, 2023

danielbachhuber requested changes Nov 27, 2023

View reviewed changes

Add mu site tests, update how recently active plugin info is fetched

805760d

Merge branch 'main' into feature/add-recently-active-option

52d77b3

thrijith closed this Mar 1, 2024

ernilambar mentioned this pull request May 2, 2024

Add --recently-active option in plugin list command #424

Merged

		@@ -0,0 +1,103 @@
		Feature: List Recently Active WordPress plugins

	if ( ! is_network_admin() ) {
	update_option(
	'recently_activated',
	array( $plugin->file => time() ) + (array) get_option( 'recently_activated' )
	);
	} else {
	update_site_option(
	'recently_activated',
	array( $plugin->file => time() ) + (array) get_site_option( 'recently_activated' )
	);
	}


		$all_items = $this->get_all_items();

		// Only show plugins that are recently active.

Conversation

thrijith commented Nov 13, 2023

Uh oh!

swissspidy commented Nov 13, 2023

Uh oh!

danielbachhuber commented Nov 13, 2023

Uh oh!

danielbachhuber Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

thrijith Dec 3, 2023

Choose a reason for hiding this comment

Uh oh!

danielbachhuber Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

thrijith Dec 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danielbachhuber Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

thrijith Dec 3, 2023

Choose a reason for hiding this comment

Uh oh!

danielbachhuber Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

thrijith Dec 3, 2023

Choose a reason for hiding this comment

Uh oh!

thrijith commented Dec 3, 2023

Uh oh!

danielbachhuber commented Dec 8, 2023

Uh oh!

thrijith commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thrijith Dec 3, 2023 •

edited

Loading