Include optional 'auto_updates' field in plugin and theme lists #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
changed the title
danielbachhuber
approved these changes
Feb 7, 2023
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Great work on this, @endriu84 ! I appreciate you taking the time to write tests, too 😊
Looks pretty solid all of the way through. I made a few tweaks you might like to look through.
Contributor
Author
|
Thank You @danielbachhuber for your review and tweaks. It feels great to have my small contribution merged into the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344
This pull request adds an optional field to the
wp plugin listandwp theme listcommand. With this change, users can now display theauto_updatescolumn when listing plugins or themes by using the--fieldoption, like this:wp plugin list --field=name,auto_updatesorwp theme list --field=name,auto_updates--format=jsonI've also updated the test suite with a test case for this scenario.
Note: This is my first contribution to this project. I'd greatly appreciate any feedback or suggestions on how I can improve my code and my contribution process. Thank you for considering this pull request!