Refactor into get_file_paths_and_names() function
#81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Let us know when you're ready for a review on this!
Member
Author
|
@danielbachhuber Yes, please. I've further changes planned – in particular to make things faster. Currently, even when |
Member
|
Functionality-wise it looks good to me so far 👍 Just merged the latest changes so that tests pass again, which is a good sign too. |
2 tasks
danielbachhuber
approved these changes
Dec 6, 2023
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks again for your work on this, @BrianHenryIE !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function/moves the logic for determining the source directory, the output directory, the output filename, and the plugin directory name the archive will extract to.
Which required moving the logic to determine the plugin version into its own function too (less attention paid here).
No change in behavior indicated through the tests. This will hopefully address #76 but I do not have a Windows setup to test it on. See the added regex on line 205 which now accounts for Windows absolute paths.
Also an opportunity for some code review as suggested yesterday.