Conversation
| || 'beta' === $assoc_args['version'] | ||
| || 'rc' === $assoc_args['version'] | ||
| || 'nightly' === $assoc_args['version'] |
There was a problem hiding this comment.
Why not use in_array here?
There was a problem hiding this comment.
Yep could do. I try to touch as few lines as possible, at least to begin with.
|
It would be nice (although not urgent) if we could pick this up again. I think if For that we need to update the Then we can use that class here |
|
If someone wants to take this over be my guest. See #17 for some more recent discussion and linked meta issues. |
|
Closing for now as there's barely any code in here, and discussion can continue on the issue. |
Fixes #17.