Unexpected HTML output when updating WordPress #191
Description
If I update WP using wp core update I get a lot of unexpected HTML output coming from WordPress itself:
$ wp core update
Updating to version 4.0 (pt_BR)...
Descompactando a atualização...
<p>Algumas traduções precisam de atualização. Descanse por mais alguns segundos, enquanto atualizamos elas também.</p>
<div class="update-messages lp-show-latest"><h4>Atualizando traduções de WordPress (pt_BR)…</h4><p>Fazendo download da tradução de <span class="code">(http://downloads.wordpress.org/translation/core/4.0/pt_BR.zip)</span>…</p>
<p>Descompactando a atualização…</p>
<p>Instalando a versão mais recente…</p>
<p>Tradução atualizada com sucesso.</p>
</div><script type="text/javascript">
(function( wp ) {
if ( wp && wp.updates.decrementCount ) {
wp.updates.decrementCount( "translation" );
}
})( window.wp );
</script></div></div>Success: WordPress updated successfully.
This output is coming from the new WP code to automatically update translations when updating core.
It seems that WP_CLI\UpgraderSkin is not being used in this context because the static method Language_Pack_Upgrader::async_upgrade() instantiate Language_Pack_Upgrader class with a hard coded skin. I guess we will have to open a new ticket on core. I decided to open an issue here first in case anyone has another idea on how to fix this.