Refactor config create command #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@UmeshSingla Can you please add tests also? Ref: Functional Tests |
ernilambar
reviewed
May 20, 2024
Contributor
Author
@ernilambar Aren't the existing tests enough? If not, Could you possibly provide me with an example of changes that can use additional tests. |
Member
For refactoring part, current tests are fine. Adding test for this issue #180 would be good. |
Contributor
Author
|
@ernilambar I've added functional test for #180. Does this looks ok to you? 0601669 |
ernilambar
approved these changes
May 20, 2024
2 tasks
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #94
Fixes #180
Refactored code for wp config create command renders the default moustache template with default values along with the
extra-phpinput if specified. And further it uses update method from WPConfigTransformer class to set the config values for all provided arguments.