Prevent WP_DEBUG already defined when provided via --extra-php#144
Merged
schlessera merged 2 commits intowp-cli:mainfrom Sep 11, 2022
Merged
Conversation
This fixes wp-cli#140 by moving the `WP_DEBUG` define after the output from `{extra_php}` and wrapping it in a conditional. This avoids the `Notice: Constant WP_DEBUG already defined` that gets thrown when `define( 'WP_DEBUG', ... );` is provided via `--extra-php`.
schlessera
requested changes
Sep 11, 2022
Co-authored-by: Alain Schlesser <[email protected]>
schlessera
approved these changes
Sep 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #140 by moving the
WP_DEBUGdefine after the output from{extra_php}and wrapping it in a conditional. This avoids theNotice: Constant WP_DEBUG already definedthat gets thrown whendefine( 'WP_DEBUG', ... );is provided via--extra-php.