Add blank space when trimming the version#130
Merged
swissspidy merged 1 commit intowp-cli:mainfrom Oct 1, 2024
Merged
Conversation
swissspidy
added
the
command:core-verify-checksums
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
verify-checksumcommand relies on the methodfind_varto get the WordPress version to check against. The version currently comes with an extra space which causes an additional character when performing the HTTP request to https://api.wordpress.org/core/checksums/1.0/.Example HTTP request performed by
verify-checksums:How it should look like:
Hope this saves some striping in the server.