Repository navigation
Commit b222709
committed
docs(decisions): three r174 kills the GL-error storm — and is still not landing tonight
Kevin authorised landing the upgrade if it works ("if the upgrade works, then do
it"), then went to sleep. It does not clear the bar I set before measuring, so it
is reverted and this is the record instead.
MEASURED, with a presence control, production bundle, identical 12s probe:
three 0.172.0 + postprocessing 6.39.1 -> 6 glBlitFramebuffer messages
three 0.174.0 + postprocessing 6.39.4 -> 0
The control is the point. A zero from an instrument never shown to produce a
non-zero is not evidence, and this repo has shipped that mistake seventeen times.
That confirms the upstream maintainer's theory on pmndrs/postprocessing#750: the
GL storm we had filed as a SEPARATE production-bundle finding and the GodRays
regression share a root cause in three r172's depth-texture handling
(mrdoob/three.js#30585, fixed r174).
A gap this exposed, worth more than the upgrade: prod-smoke.mjs CANNOT SEE this
error class. It filters on m.type() === 'error' and these arrive as 'warning', so
the repo's own production gate is structurally blind to the error storm it exists
to watch.
WHY IT IS NOT LANDING: r174 changes the whole look. 19 of 31 frames go over gate,
many at 99%+ local density, and the sky is visibly more saturated -- a global
colour/tone change, not one subsystem regressing. Landing it means rewriting all
31 baselines, which is a judgement about how the game should LOOK. That is
Kevin's call, not a correctness fix the loop can self-gate, and a bundled
engine-bump + re-baseline is precisely the shape baseline-trailer exists to stop.
It also runs against c1d933e, which deliberately blocks 0.x MINOR bumps for the
engine stack. This measurement is evidence FOR that policy.
Reverted fully: package.json + package-lock.json restored from backup, npm ci
re-run, 0.172.0 / 6.39.1 confirmed installed, tree clean.
The upstream reply is DRAFTED, NOT POSTED -- a public upstream comment is
outward-facing and stays Kevin's. It says plainly that I cannot yet confirm r174
fixes the SUN, because the global change makes that unseparable without a
controlled r174 pair I have not run.1 parent b0147d5 commit b222709
2 files changed
Lines changed: 95 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
21 | 77 | | |
22 | 78 | | |
23 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
0 commit comments