Repository navigation
Commit 9c52cd0
committed
fix(docs): correct two claims of mine that measurement disproved — the MSAA figure and the GL attribution
Kevin asked whether the postprocessing issue we filed was relevant to the sun-arc work. It was, and the
answer corrected two things I had written into this repo.
1. THE MSAA FIGURE WAS ~2x TOO LARGE. I computed ~471 MB from the REQUESTED sample count (8). Measured on
a real ANGLE Metal / Apple M3 Max context, `MAX_SAMPLES` reads **4** — so the requested 8 was always
being clamped and never granted. The true cost is ~236 MB at dpr 2. Half the figure; the verdict is
unchanged, because a redundant multisampled buffer reallocated on every canvas resize is still
redundant and SMAA is still the thing doing the antialiasing.
2. MY GL-STORM HYPOTHESIS IS REFUTED, not merely unconfirmed. I had named the per-frame MSAA resolve as
the prime suspect for the `GL_INVALID_OPERATION: glBlitFramebuffer` storm, hedged as unverified. A
controlled pair on the real GPU settles it:
<EffectComposer multisampling> frames GL errors
0 (my change) 1672 0
package default 1783 0
Identical. The MSAA path is uninvolved. The fix was upstream — postprocessing 6.39.5 (078a6d1) stopped
EffectComposer building its stable depth texture with `DepthTexture.clone()`, which on three r172
shares one GPU image between a texture and its clones (three.js#30540, milestone r174).
I ran that control specifically because I was about to report upstream, and the one hypothesis I was least
motivated to test was the one that removes my own contribution from the explanation. Without it I would
have credited our change to a maintainer who had already solved it.
POSTED, now that there is a measurement behind it:
- pmndrs/postprocessing#750 — confirming the fix works on three r172, which is what he asked us to
verify and we never did. He closed it on an assumption for our configuration; it is now verified.
- N8python/n8ao#53 — a data point: their matrix stops at postprocessing 6.39.1 and reports no effect;
6.39.5 is clean here WITH `halfRes` enabled. Explicitly labelled as current-state, not a before/after,
since I did not reproduce the failure first.
THREE DEAD INSTRUMENTS were caught getting there, each by its own control, and all three returned a clean
zero that nothing could have made non-zero:
- `prod-smoke` launches `--use-angle=swiftshader` in CI exactly as locally. SwiftShader does not perform
the driver-side validation that emits this error, so its seeded 0 was structurally guaranteed. That
limit is already written into the file; the GL ledger is a SwiftShader-path regression guard only.
- a tab opened in the operator's Chrome read `visibilityState: hidden` with a rAF probe of 0 and a canvas
still at 300x150 — a backgrounded tab renders nothing, so 0 errors over 0 frames. Caught by this
repo's own rule that a zero denominator is COULD-NOT-CHECK rather than a pass.
- CDP `Runtime.evaluate` timeouts, twice, from putting a 60s wait loop inside a 45s call.
Only a headless launch with `--use-angle=metal`, renderer string confirmed and 1672 real frames behind it,
produced a reading worth reporting.
No gate changes: this commit corrects prose in a source comment, a test docblock and the cursor. The
effect-chain-cost cases are untouched and still pass.1 parent 673ecde commit 9c52cd0
3 files changed
Lines changed: 33 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
312 | | - | |
313 | | - | |
314 | | - | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
315 | 317 | | |
316 | 318 | | |
317 | 319 | | |
318 | 320 | | |
319 | 321 | | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
326 | 331 | | |
327 | 332 | | |
328 | 333 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
36 | 49 | | |
37 | 50 | | |
38 | 51 | | |
39 | | - | |
| 52 | + | |
40 | 53 | | |
41 | 54 | | |
42 | 55 | | |
| |||
0 commit comments