Repository navigation
Commit 673ecde
committed
fix(ci): knip red on my own probe, and the GL ledger cannot answer the question it was built for
TWO THINGS, and the second matters more than the first.
KNIP. CI went red on `knip (unused files / exports / deps)` — "Unlisted binaries (1): uptime
scripts/visual/gpu-cost-probe.mjs". Mine, from this session. Fixed by removing the dependency rather than
allowlisting it: `os.loadavg()` is a Node builtin, so there is no subprocess, no PATH assumption, no
output parsing and no platform question. An `ignoreBinaries` entry would have silenced the finding while
leaving the dependency in place, which is the worse of the two repairs and the tempting one.
THE GL LEDGER'S FIRST READING IS NOT THE ANSWER IT LOOKS LIKE.
CI seeded it: `prod-smoke: GL errors: 0 over 8 frames — NO LEDGER YET, recording this as the ceiling.`
That reading is worth stating clearly because it is about to be quoted as if the storm were fixed, and it
is not evidence of that.
`prod-smoke` launches with `--use-angle=swiftshader` — in CI exactly as locally. SwiftShader is a CPU
rasteriser. It reports MAX_SAMPLES 4, it does not perform the driver-side validation that emits
`GL_INVALID_OPERATION: glBlitFramebuffer: Read and write depth stencil attachments cannot be the same
image`, and the storm was only ever OBSERVED in a real Chrome on a real GPU. A 0 from it is exactly the
reading a driver that CANNOT raise the error would always produce.
So the ledger is a regression guard for the SwiftShader path and nothing more. It will catch a new GL
error class that even SwiftShader validates; it cannot confirm the real-driver storm is gone. That limit
is now written into the file, because a ledger seeded at 0 reads like an all-clear, and an all-clear from
an instrument that cannot see the subject is the DEGRADED shape — the one that looks like success and is
the most dangerous of the three.
CONSEQUENCE FOR THE UPSTREAM DECISION. I said I would not comment on pmndrs/postprocessing#750 or
N8python/n8ao#53 until there was a real-browser measurement. There still is not one. This reading does not
change that, and reporting it upstream would be handing a maintainer a number from a rasteriser that
cannot produce the symptom. The only instrument that can settle it is a real GPU — which on this machine
means the operator's own Chrome, where the original ~256-per-load observation came from.
Not gated beyond the existing gl-error-ledger tests: this commit changes a docblock and swaps a subprocess
for a builtin. The behaviour under test is unchanged and its six cases still pass.1 parent 44eb7f3 commit 673ecde
2 files changed
Lines changed: 30 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
57 | 76 | | |
58 | 77 | | |
59 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
0 commit comments