Skip to content

Accept arm64 as an alias for aarch64 - #161

Merged
workhorsy merged 2 commits into
workhorsy:masterfrom
bobrik:ivan/arm64
Apr 8, 2021
Merged

Accept arm64 as an alias for aarch64#161
workhorsy merged 2 commits into
workhorsy:masterfrom
bobrik:ivan/arm64

Conversation

@bobrik

@bobrik bobrik commented Feb 28, 2021

Copy link
Copy Markdown
Contributor

Closes #159.

@bobrik bobrik mentioned this pull request Feb 28, 2021
Closed
@bobrik bobrik mentioned this pull request Mar 6, 2021
Open
@vincentsarago vincentsarago mentioned this pull request Apr 7, 2021
Closed
@jakirkham

jakirkham commented Apr 7, 2021

Copy link
Copy Markdown

@workhorsy, could you please review this when you have a chance? 🙂

@admiral2

admiral2 commented Apr 8, 2021

Copy link
Copy Markdown

Adding ARM64 to _parse_arch allow to use py-cpuinfo on Windows Surface with ARM Microsoft SQ1 CPU

get_cpu_info() output is:

python_version: 3.7.8.final.0 (32 bit)
cpuinfo_version: [7, 0, 0]
cpuinfo_version_string: 7.0.0
arch: ARM_8
bits: 64
count: 8
arch_string_raw: ARM64
vendor_id_raw: Qualcomm Technologies Inc
brand_raw: Microsoft SQ1 @ 3.0 GHz
hz_advertised_friendly: 3.0000 GHz
hz_actual_friendly: 1.4200 GHz
hz_advertised: [3000000000, 0]
hz_actual: [1420000000, 0]
l2_cache_size: 1310720
model: 805
family: 8
l3_cache_size: 4096000

@workhorsy

workhorsy commented Apr 8, 2021

Copy link
Copy Markdown
Owner

Just did some quick research. Looks like arm64 and aarch64 are basically the same:
https://stackoverflow.com/questions/31851611/differences-between-arm64-and-aarch64

Tested on Linux, Windows, and OSX.

@workhorsy
workhorsy merged commit f3ec858 into workhorsy:master Apr 8, 2021
@jakirkham

jakirkham commented Apr 8, 2021

Copy link
Copy Markdown

Thanks Matthew! 😄

@fjetter fjetter mentioned this pull request Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error while initializing the quicklook plugin (py-cpuinfo currently only works on X86 and some PPC and ARM CPUs.)

4 participants

@bobrik @jakirkham @admiral2 @workhorsy