This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Merged
Conversation
Tug
force-pushed
the
upgrade/react-native
branch
from
166efe4 to
6ab9578
Compare
|
👋 @Tug , can you add some description on why it is necessary to upgrade the RN version here and what problem does it cause if left unaltered? Thanks! |
|
As discussed, can we do the same change as per wordpress-mobile/react-native-aztec@ab4b1fe here? |
Author
|
Updated 👍 |
mzorz
approved these changes
Nov 19, 2018
mzorz
left a comment
mzorz
left a comment
There was a problem hiding this comment.
LGTM! tested, haven't been able to spot (new) hiccups here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading react-native to 0.57.5 in
gutenberg-mobilewill require some changes inreact-native-recyclerview-listas some internal react native classes have changed:ScrollEventTypeenum's methodgetJSEventNameis now static