This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Fix waiting on caret rect detection when caret is at the end#5
Merged
Fix waiting on caret rect detection when caret is at the end#5
Conversation
1 task
etoledom
approved these changes
Feb 22, 2019
etoledom
left a comment
There was a problem hiding this comment.
Looks good and works well ✨
Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the waiting when we tap at the end of the text. Not sure about the root cause but it seems like caret y position can not be determined when it is at the end of the text. There are some similar issues on the web but no solutions. So this is a workaround but we can happily fallback to scrolling till the bottom of the component when caret is at the end anyway. And it is already what JS side does when we can't detect caret's position.
Problematic case:
Will add WPiOS PR here.
TO TEST:
Also: