Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Upgrade react-native and use a more permissive peer dependency requirement#74

Merged
Tug merged 4 commits intomasterfrom
upgrade/react-native
Nov 19, 2018
Merged

Upgrade react-native and use a more permissive peer dependency requirement#74
Tug merged 4 commits intomasterfrom
upgrade/react-native

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented Nov 19, 2018

This PR updates react-native peer dependency to 0.57.5 and react to 16.6.1 (peer dependency of react-native)

I don't think it's useful to set fixed version here as it's best to be a bit flexible on what version of react native gutenberg-mobile can use with this lib.
**Edit: ** let's be on the safe side and use fixed versioning here

@mzorz mzorz self-requested a review November 19, 2018 11:21
@koke
Copy link
Copy Markdown
Member

koke commented Nov 19, 2018

In the PR I’m doing for the app integration, the Podspec file is reading the react native version from package.json and needs a fixed version. Besides, it’s probably better to make upgrades explicit to avoid surprises

@koke
Copy link
Copy Markdown
Member

koke commented Nov 19, 2018

I just realized this is in the Aztec component repo. Ignore me 😬

@mzorz
Copy link
Copy Markdown
Contributor

mzorz commented Nov 19, 2018

it’s probably better to make upgrades explicit to avoid surprises

Agreed with this I think it's preferrable for us to have RN as a fixed version - even if we mostly use this project only within the context of gutenberg-mobile, I think it's better to make things explicit so it's easier to have in mind there was a change in version if we want to count that as a possible source of errors when tracking issues

Copy link
Copy Markdown
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@mzorz
Copy link
Copy Markdown
Contributor

mzorz commented Nov 19, 2018

Forgot to mention: I did some smoke tests with writing and such on the demo app just to make sure things look good 👍

@Tug Tug merged commit 08916a6 into master Nov 19, 2018
@Tug Tug deleted the upgrade/react-native branch November 19, 2018 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants