This repository was archived by the owner on Mar 7, 2025. It is now read-only.
[Android] Add the ability to set font family, weight, size, and style from RN#114
Merged
daniloercoli merged 1 commit intomasterfrom Jan 23, 2019
Conversation
mzorz
approved these changes
Jan 23, 2019
Contributor
mzorz
left a comment
mzorz
left a comment
There was a problem hiding this comment.
Tested by copying all the changes on WPAndroid's develop. Works well, but this will need to be moved to the main gutenberg-mobile repo as discussed.
LGTM!
daniloercoli
deleted the
add/ability-to-change-font-family-weight-style-from-RN
branch
This was referenced Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set font family, weight, size, and style from RN.
Setting the proper font Family is required by our parent app, and there is no reliable way to set them in CSS/Style. We've then decided to follow the approach suggest by RN docs, and checked the default React Native TextInput component.
All of the code in this PR is taken from
ReactTextInputManagerclass.Before start using it in wordpress-mobile/gutenberg-mobile#450 we need the same properties added to iOS.
To test it, just apply this GIST https://gist.github.com/daniloercoli/11f917e4cf1ee046875edbc843d9e85a to your local copy of GB and run the app as usual.