Skip to content

Introduce paragraph block and RichText component for mobile#81

Merged
hypest merged 17 commits intomasterfrom
feature/introduce-para-block
Aug 3, 2018
Merged

Introduce paragraph block and RichText component for mobile#81
hypest merged 17 commits intomasterfrom
feature/introduce-para-block

Conversation

@daniloercoli
Copy link
Copy Markdown
Contributor

@daniloercoli daniloercoli commented Jul 26, 2018

This PR is branched on the top of #80 "Update to latest GB master", so don't merge this before.

Pretty simple PR in this repository:

  • Changed the demo app that now loads & parses valid Paragraph blocks from HTML code.
  • Use an updated version of GB hash that added support for:
    -- RichText component on mobile (still need to optimize it a little bit better)
    -- Add a Paragraph block for mobile

Most of the work was done in a separate branch/PR in the Gutenberg repository here:
https://github.com/WordPress/gutenberg/tree/rnmobile/port-para-block-use-latest-gb-master-july

iOS: No errors, but para blocks are empty.

…lock for mobile, and RichText component for mobile, and feed GB mobile with new demo HTML content.
@daniloercoli
Copy link
Copy Markdown
Contributor Author

Relevant GB PR here: WordPress/gutenberg#8231

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Jul 27, 2018

On the iOS simulator, it seems that something goes wrong with the rendering and Aztec is rendered on what seems to be 2 blocks:
screen shot 2018-07-27 at 10 59 30

Anything we can do about it on this PR? cc @SergioEstevao

@SergioEstevao
Copy link
Copy Markdown
Contributor

I think this need to be update on Aztec library itself, @diegoreymendez may now more details.

@daniloercoli
Copy link
Copy Markdown
Contributor Author

Validation errors when I start typing into AzteciOS due to p tags being introduced in the content. (Those should be br).
screen shot 2018-07-27 at 10 46 56

@diegoreymendez
Copy link
Copy Markdown
Contributor

@daniloercoli - I ended up merging my PR since the review was finished today. Once merging the changes in this PR you should see the Aztec iOS issues mentioned above go away.

Let me know if you need help resolving the conflicts.

@daniloercoli
Copy link
Copy Markdown
Contributor Author

Thanks @diegoreymendez - Yes, I've been in chat with @SergioEstevao yesterday, and we decided to review your PR first. He is working on making the merge back to this PR.

SergioEstevao and others added 3 commits July 31, 2018 13:08
# Conflicts:
#	src/block-management/block-holder.js
…le typing issue 6afc3c5

Update GB hash that includes the latest code from PR review comments.
@hypest hypest self-assigned this Aug 3, 2018
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine! This is such a great progress :) Thanks!

@hypest hypest merged commit f47cc5d into master Aug 3, 2018
@hypest hypest deleted the feature/introduce-para-block branch August 3, 2018 11:50
mzorz added a commit that referenced this pull request Nov 28, 2018
@mzorz mzorz mentioned this pull request Nov 28, 2018
hypest pushed a commit that referenced this pull request Jan 3, 2019
Use focusTextInput and blurTextInput  codes from RN's ReactTexInputManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants