Conversation
And keep avoiding that propagetion on Android to avoid regression of #302
SergioEstevao
left a comment
There was a problem hiding this comment.
Working correctly on iOS.
|
@daniloercoli or @mzorz or @marecar3 could you please check the Android side? |
|
Hey @etoledom, nice work here! :) I just found one case on Android platform which is maybe interesting. |
|
@marecar3 - Thanks for the review!
Sounds good! I'll check that out. |
|
@marecar3 - I gave your suggestion a try, but it's more complicated than I thought. The I searched for a way to intercept that button on "Hide Keyboard" mode, and I couldn't find any. I also tried using keyboard events, but those are too generic, and we don't want to unselect the block for every time the keyboard is dismissed (i.e. presenting the Links UI). I'd suggest to create a new ticket for this, since it's not actually related to our Hide Keyboard toolbar button, and it seems to not be a simple fix. |
|
Thank you both! :) |
fixes #702
This PR fixes an issue that made the Hide-Keyboard toolbar button not work after the Links UI bottom-sheet was dismissed.
Additionally, now on both platform, dismissing the keyboard with this button will clear the block selection.
To test (iOS):
To test (Android):
Note: On Android, the keyboard is already hidden after dismissing the Links UI.