Merged
Conversation
Merged
5 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Fix: #725
This PR removes formatting controls that appear on iOS side when we select text from post title.
gutenberg PR: WordPress/gutenberg#14435
WPiOS PR: wordpress-mobile/WordPress-iOS#11275
After the fix:
To Test
WPiOS
Checkout branch at [Gutenberg]Disable editing menu on post title WordPress-iOS#11275
Open the WPiOS app with an iPad
Select a text at title
Verify that formatting options aren't available in the menu above the keyboard
Verify that formatting options aren't available in the menu above the selected text
Select a text in a paragraph block
Verify that formatting options are available this time
WPAndroid << also important