Merged
Conversation
hypest
approved these changes
Mar 7, 2019
Contributor
hypest
left a comment
hypest
left a comment
There was a problem hiding this comment.
Thanks for all the fish Travis CI! The service was really key to the developer experience of the project so far. Most notable: the Android JS bundles were created during the Travis CI build and pushed to AWS for some time until we migrated to using JitPack for bundling those within an aar. So yeah, thanks! 👋
@jtreanor this LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CircleCI has been running reliably for a while now so I am removing the Travis config. It is not needed anymore.