Merged
Conversation
Contributor
As discussed over Slack, @mzorz will wrangle the Android side 👍. In other news, @etoledom can you cherry pick this #696 too so we can have CircleCI turn green too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a Hotfix to include #694 into WPiOS v11.9.
I have:
gutenberg-mobile.Since the change is only native (iOS) code, it didn't seem relevant to build new JS Bundles.
To test:
WPiOS:
Android:
@hypest - I'm not clear if we agreed on updating WPAndroid too. If that the case, I will need help with that. Adding the
Needs Android Devlabel just in case.