Skip to content

Add CircleCI config#696

Merged
jtreanor merged 1 commit intodevelopfrom
circleci
Mar 1, 2019
Merged

Add CircleCI config#696
jtreanor merged 1 commit intodevelopfrom
circleci

Conversation

@jtreanor
Copy link
Copy Markdown
Contributor

@jtreanor jtreanor commented Mar 1, 2019

Adding a CircleCI config for this repo. I have moved .travis/travis-checks-js.sh to bin/ci-checks-js.sh so that it can be shared by Travis and CircleCI.

After this has been running for a while, I will turn off Travis got the repo.

To test:

  • CircleCI checks are ✅

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jtreanor jtreanor requested review from hypest and loremattei March 1, 2019 11:48
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super nice @jtreanor , thanks for adding CircleCI support!

I've only left a not-so-major comment, please have a look. Thanks!

Copy link
Copy Markdown
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jtreanor jtreanor merged commit 5536240 into develop Mar 1, 2019
@jtreanor jtreanor deleted the circleci branch March 1, 2019 15:17
@hypest hypest mentioned this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants