Use different block minHeight between the platforms#664
Merged
hypest merged 4 commits intorelease/1.0.1from Feb 24, 2019
Merged
Use different block minHeight between the platforms#664hypest merged 4 commits intorelease/1.0.1from
hypest merged 4 commits intorelease/1.0.1from
Conversation
Currently, each mobile platform has different internal paddings in Aztec so, need to set different block minHeights for each platform.
5 tasks
mzorz
approved these changes
Feb 24, 2019
Contributor
mzorz
left a comment
mzorz
left a comment
There was a problem hiding this comment.
LGTM! As discussed via slack 
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #666
Currently, each mobile platform has different internal paddings in Aztec so, need to set different block minHeights for each platform.
Gutenberg side PR: WordPress/gutenberg#14070
To test: