Update i18n cache translation urls and new languages#659
Merged
Conversation
…re than 50% translated
hypest
reviewed
Mar 4, 2019
| ]; | ||
|
|
||
| const getLanguageUrl = ( locale ) => `https://widgets.wp.com/languages/gutenberg/${ locale }.json`; | ||
| const getLanguageUrl = ( locale ) => `https://translate.wordpress.org/projects/wp-plugins/gutenberg/dev/${ locale }/default/export-translations\?format\=json`; |
Contributor
There was a problem hiding this comment.
Do we have a good understanding of which code commit is the dev (Development on GlotPress) channel corresponding to? And in particular, how can we know that it perfectly matches the code version of gutenberg-mobile?
Contributor
There was a problem hiding this comment.
Will go ahead and merge this PR. It'd still be useful if we can document the potential mismatch between our code version and the translations version on GlotPress.
Contributor
|
Tug is AFK these days and I'd prefer if we include this work in the code freeze today so, will merge this myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
i18n-cachemodule to fetch the translation files from https://translate.wordpress.org/projects/wp-plugins/gutenberg directly instead of wp.me.It also adds new languages that seems to be supported.
Testing Instructions
yarn clean:i18n-cacheyarn i18n-cachei18n-cache/data