Skip to content

Fix title padding on Android#655

Merged
pinarol merged 3 commits intorelease/1.0from
fix/android-title-padding
Feb 22, 2019
Merged

Fix title padding on Android#655
pinarol merged 3 commits intorelease/1.0from
fix/android-title-padding

Conversation

@pinarol
Copy link
Copy Markdown
Contributor

@pinarol pinarol commented Feb 22, 2019

This PR separates the title padding styles of iOS and Android and removes the vertical paddings of post title on Android because Android handles the paddings on native side.

Changes reside in gutenberg PR WordPress/gutenberg#14057

@pinarol
Copy link
Copy Markdown
Contributor Author

pinarol commented Feb 22, 2019

@hypest ready for another look

@pinarol pinarol requested a review from hypest February 22, 2019 16:06
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's update to the merged Gutenberg hash and we can merge this too! Edit: heh. beat me to it :)

@pinarol pinarol merged commit d0cb028 into release/1.0 Feb 22, 2019
@pinarol pinarol deleted the fix/android-title-padding branch February 22, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants