Merged
Conversation
Make sure the locale data is setup before importing anything, since block names get translated on import
The change there was for the unsupported blocks PR
hypest
reviewed
Feb 22, 2019
src/index.js
Outdated
| AppRegistry.registerComponent( 'gutenberg', () => RootComponent ); | ||
| } | ||
|
|
||
| export function setupApp() { |
Contributor
There was a problem hiding this comment.
Nit, let's call this bootstrapEditor or something. The "App" moniker starts to feel too vague, WDYT? :)
hypest
approved these changes
Feb 22, 2019
Contributor
hypest
left a comment
hypest
left a comment
There was a problem hiding this comment.
LGTM!
Loving my i18n'd block names on the Inserter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, the block titles were not being translated because the translation attempt happened before the locale data was set up.
This refactors the initialization process to ensure we setup localization before Gutenberg is imported
This was originally implemented as part of #643 but that one isn't ready to merge yet
To Test