Merged
Conversation
Contributor
Author
|
Ping @mkevins - Please review and add comments if necessary. Thanks! |
5 tasks
Contributor
|
I tested this on Android, and it fixes a similar issue where the selection context menu was not going away after clicking paste. |
hypest
changed the title
etoledom
approved these changes
Feb 22, 2019
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
Tested on iOS and it fixes the mentioned issue. 🎉
Contributor
|
Will merge this to include in today's release. |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Moves forward #624
Fixes pasting links. The content was being updated properly, but the native component was not being refreshed right in iOS, and the change was being lost.
The format bar was showing the existence of a link but the text was just not showing it.
Dependencies:
Gutenberg PR: WordPress/gutenberg#14038
Testing:
Make sure the link is properly shown.