Re-add rootTagsToEliminate option to RichText#636
Merged
Conversation
5 tasks
koke
approved these changes
Feb 21, 2019
Member
koke
left a comment
koke
left a comment
There was a problem hiding this comment.
Tested on WPiOS and it looks good 👌
daniloercoli
added a commit
that referenced
this pull request
Feb 22, 2019
…rg-mobile into issue/609-Show-Title-block-when-HTML-mode * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (44 commits) Updated bundles Add border on Title when focused (#622) Default to the device language for the example app Updates the gutenberg submodule ref. Updates the gutenberg submodule reference. Re-add rootTagsToEliminate option to RichText (#636) Give priority to the parent app translations Remove unnecessary import Fix lint issue Fallback to a locale without a regional code if not supported Add Greek support PR got merged upstream so, use upstream Run yarn i18n-cache on postinstall Run yarn prebundle before bundle:android and bundle:ios instead Use a forked+patched jsdom-jscore with normalization fix Revert "Update GB ref with fix for node.rel" Upload media progress bar is missing while media is uploading new (#631) Remove JS handling of title focus Update GB ref with fix for node.rel Update iOS translation values as arrays ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to re-add rootTagsToEliminate option to RichText component. Looks like it was lost by a merge regression here https://github.com/WordPress/gutenberg/pull/13874/files
Original issue was resolved here #577.
gutenberg PR needs to be merged first WordPress/gutenberg#14006
TO TEST
Follow test steps in original PR: #577
(feel free to test on develop branches on WPiOS and WPAndroid).