Skip to content

Fix for node.rel crash#630

Merged
hypest merged 4 commits intodevelopfrom
fix/red-screen-pasting-from-particular-site
Feb 21, 2019
Merged

Fix for node.rel crash#630
hypest merged 4 commits intodevelopfrom
fix/red-screen-pasting-from-particular-site

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Feb 20, 2019

Addresses at least one case of "Pasting from some sources causes a red screen (related comment)" from #624

To test:

  1. On the mobile, open the browser and copy the "Gravity Forms" text (it's a link) from https://designsbytierney.com/2010/01/how-to-add-edit-format-text-in-a-wordpress-post-or-page/
  2. Run the demo app
  3. In a paragraph block, paste
  4. It should work and the link be available in the block

@hypest hypest added this to the Beta milestone Feb 20, 2019
@hypest hypest mentioned this pull request Feb 20, 2019
Closed
5 tasks
diegoreymendez
diegoreymendez approved these changes Feb 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get the mentioned red screen to pop-up.

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Feb 21, 2019

Thanks for the pass @diegoreymendez !

I will actually need to update this PR to host a different solution as, I closed the Gutenberg side PR as invalid. Will report here again soon.

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Feb 21, 2019

Ready for another pass!

This time, the solution uses this PR opened against the jsdom-jscore library repo we're using.

@mkevins
Copy link
Copy Markdown
Contributor

mkevins commented Feb 21, 2019

This time, the solution uses this PR opened against the jsdom-jscore library repo we're using.

I think this will make a lot of things easier. Does this mean we can move some (maybe all?) of the jsdom-patches?

@hypest hypest changed the title Update GB ref with fix for node.rel Fix for node.rel crash Feb 21, 2019
@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Feb 21, 2019

Does this mean we can move some (maybe all?) of the jsdom-patches?

Most probably, but let's wait until after our release this coming days so we don't shake things up too much.

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Feb 21, 2019

jscore-jsdom-rn upstream accepted our PR so, will update this branch to use the upstream.

@diegoreymendez diegoreymendez self-requested a review February 21, 2019 14:03
diegoreymendez
diegoreymendez approved these changes Feb 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I can't manage to reproduce the original issue. Nice work!

@hypest hypest merged commit 8ee7064 into develop Feb 21, 2019
@hypest hypest deleted the fix/red-screen-pasting-from-particular-site branch February 21, 2019 14:54
This was referenced Feb 22, 2019
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diegoreymendez diegoreymendez diegoreymendez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Beta

Development

Successfully merging this pull request may close these issues.

3 participants

@hypest @mkevins @diegoreymendez