Skip to content

Remove unnecessary <strong> tags from post title #577

Merged
pinarol merged 3 commits intorelease/0.3.5from
fix/strong-tags-on-title
Feb 8, 2019
Merged

Remove unnecessary <strong> tags from post title #577
pinarol merged 3 commits intorelease/0.3.5from
fix/strong-tags-on-title

Conversation

@pinarol
Copy link
Copy Markdown
Contributor

@pinarol pinarol commented Feb 8, 2019

This is a quick workaround to remove <strong> tags from post title. We can see those tags on Aztec editor.

title-strong-tag2

Changes reside in WordPress/gutenberg#13763

To Test

Test both on WPAndroid and WPiOS
Main apps PRs: wpandroid, wpios.

  1. Test with a new post
  • Open a new post
  • Type a title
  • Switch to Classic editor
  • Verify that you don't see <strong> tags
  1. Test with an existing post
  • Open an existing post with a title
  • Switch to Classic editor
  • Verify that you don't see <strong> tags
  1. Test we don't affect other blocks
  • Open a post and add a paragraph/heading block
  • Select all and make bold
  • Switch to classic editor and see boldness didn't get lost

@pinarol pinarol self-assigned this Feb 8, 2019
@pinarol pinarol added this to the Beta milestone Feb 8, 2019
@daniloercoli
Copy link
Copy Markdown
Contributor

Tested on wp-android (by using the branch pointed above, and then updating the ref to this branch), and it worked fine!

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the original issue and this effectively fixes the problem. 🎉
Tested on WPiOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants