Skip to content

Implementing Clear All Settings button on Image Settings#571

Merged
etoledom merged 5 commits intodevelopfrom
issue/image-settings-revert-button
Feb 12, 2019
Merged

Implementing Clear All Settings button on Image Settings#571
etoledom merged 5 commits intodevelopfrom
issue/image-settings-revert-button

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Feb 7, 2019 •
edited
Loading

This PR updates the gutenberg ref to test the implementation of the Reset to Original Clear All Settings button on Image Settings.

clear-settings

To test:

cc @iamthomasbishop

@etoledom etoledom added the [Type] Enhancement Improves a current area of the editor label Feb 7, 2019
@etoledom etoledom added this to the Beta milestone Feb 7, 2019
@etoledom etoledom self-assigned this Feb 7, 2019
@etoledom etoledom requested a review from marecar3 February 7, 2019 21:43
@etoledom etoledom mentioned this pull request Feb 7, 2019
Merged
@etoledom etoledom removed the request for review from marecar3 February 11, 2019 08:41
@etoledom etoledom changed the title Implementing Reset to Original button on Image Settings Implementing ~Reset to Original~ Clear All Settings button on Image Settings Feb 11, 2019
@etoledom etoledom changed the title Implementing ~Reset to Original~ Clear All Settings button on Image Settings Implementing ~Reset to Original~ Clear All Settings button on Image Settings Feb 11, 2019
@etoledom etoledom changed the title Implementing ~Reset to Original~ Clear All Settings button on Image Settings Implementing Clear All Settings button on Image Settings Feb 11, 2019
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Feb 11, 2019

Change the button title to Clear All Settings and updated the gif in the description.

hypest
hypest approved these changes Feb 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Feel free to update when the Gutenberg side PR gets merged and then merge this one too 👍

@etoledom etoledom merged commit c3a483f into develop Feb 12, 2019
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Feb 12, 2019

Thank you!

@etoledom etoledom deleted the issue/image-settings-revert-button branch February 12, 2019 14:36
@etoledom etoledom mentioned this pull request May 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hypest hypest hypest approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@etoledom etoledom

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

Beta

Development

Successfully merging this pull request may close these issues.

2 participants

@etoledom @hypest