Skip to content

Fixes an issue with the font in the title and placeholder for the title.#568

Merged
diegoreymendez merged 2 commits intorelease/0.3.5from
try/fix-issue-with-post-title-style
Feb 7, 2019
Merged

Fixes an issue with the font in the title and placeholder for the title.#568
diegoreymendez merged 2 commits intorelease/0.3.5from
try/fix-issue-with-post-title-style

Conversation

@diegoreymendez
Copy link
Copy Markdown
Contributor

Description:

Fixes an issue that was causing the title font to be wrong, if emptied (or when creating a new post in WPiOS).

Also fixes #563

Testing:

  1. Empty the title
  2. Make sure the placeholder font and vertifcal alignment look fine.
  3. Switch to HTML mode and back and make sure the title's font is right.

@diegoreymendez diegoreymendez added the [Type] Bug Something isn't working label Feb 7, 2019
@diegoreymendez diegoreymendez added this to the Beta milestone Feb 7, 2019
@diegoreymendez diegoreymendez self-assigned this Feb 7, 2019
@iamthomasbishop
Copy link
Copy Markdown
Contributor

iamthomasbishop commented Feb 7, 2019

Make sure the placeholder font and vertical alignment look fine.

Can we also make sure this is tested with multi-line titles? Thank you in advance, and sorry if this has already been taken into consideration 😄

Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good 🎉

@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Feb 7, 2019

multi-line title also looks alright

title-strong-multiline

@diegoreymendez
Copy link
Copy Markdown
Contributor Author

Can we also make sure this is tested with multi-line titles? Thank you in advance, and sorry if this is already been taken into consideration 😄

On top of @pinarol 's tests... the placeholder is never shown in multiple lines right now.

@diegoreymendez diegoreymendez merged commit 9e76613 into release/0.3.5 Feb 7, 2019
@diegoreymendez diegoreymendez deleted the try/fix-issue-with-post-title-style branch February 7, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants