Skip to content

Adds placeholder coloring support for mobile's rich text component.#560

Merged
hypest merged 4 commits intorelease/0.3.5from
try/add-placeholder-support-for-rich-text-mobile
Feb 7, 2019
Merged

Adds placeholder coloring support for mobile's rich text component.#560
hypest merged 4 commits intorelease/0.3.5from
try/add-placeholder-support-for-rich-text-mobile

Conversation

@diegoreymendez
Copy link
Copy Markdown
Contributor

@diegoreymendez diegoreymendez commented Feb 7, 2019

Description:

Adds placeholder support for mobile's rich text component.

Related PRs:

Gutenberg: WordPress/gutenberg#13738

Known issues:

The placeholder font and size can't be set yet.

Testing:

Just run the app and make sure the placeholders are lightly colored. Also make sure the placeholder shows for the title.

@diegoreymendez diegoreymendez changed the base branch from develop to release/0.3.5 February 7, 2019 14:57
@diegoreymendez diegoreymendez added the [Type] Enhancement Improves a current area of the editor label Feb 7, 2019
@diegoreymendez diegoreymendez self-assigned this Feb 7, 2019
@diegoreymendez diegoreymendez added this to the Beta milestone Feb 7, 2019
@diegoreymendez diegoreymendez changed the title Adds placeholder support for mobile's rich text component. Adds placeholder coloring support for mobile's rich text component. Feb 7, 2019
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (will wait for the JS bundles to be updated and added to this PR first)

@hypest hypest merged commit 983e03f into release/0.3.5 Feb 7, 2019
@hypest hypest deleted the try/add-placeholder-support-for-rich-text-mobile branch February 7, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants