Bring placeholder text back on RichText powered blocks#544
Merged
Conversation
hypest
approved these changes
Feb 7, 2019
Contributor
|
By the way, I noticed that the vertical aligning of the placeholder is a bit off on iOS, when compared to the title text itself. See this gif:
Not a blocker for this PR so, maybe @diegoreymendez can have a look? |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue of missing placeholder text was noticed and reported since the Title block is now using the RichText component, but the problem was there on other blocks already. See Para and Heading.
This GB PR does fix the problem: WordPress/gutenberg#13699
To test:
Start the demo app and try add blocks. The placeholder text should be visible on the para or heading block.
Use wp-android and point to this branch, and enable build from code ON. Start a new post. You should see the placeholder.