Conversation
Member
|
The right-aligned text field looked good when static, but feels weird while typing. @iamthomasbishop what do you think? |
marecar3
approved these changes
Feb 4, 2019
f0500ea to
9c120fa
Compare
5 tasks
Contributor
|
@koke I agree it's not perfect, but there are a number of considerations here and for the beta the alternatives aren't better, imo. I'd like to play with this in a test build before deciding to pivot. Some alternatives that come to mind:
Long-term solution in my mind would be to iterate on this to utilize native table navigation/input patterns, for example:
Another option would be to stack a fresh sheet on top for entry, but that sounds like it could get visually disjointed if we start pulling sheets on top of sheets on top of sheets :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Gutenberg reference to test the Alt image setting.
The main PR is found here: WordPress/gutenberg#13631
To test, refer to the
gutenbergside PR.(Updated GIF)

cc @iamthomasbishop