Make heading styling distinguishable from paragraph#525
Merged
Conversation
This was referenced Jan 30, 2019
Post Editor - Make heading style distinguishable from paragraph
wordpress-mobile/WordPress-iOS#10912
Merged
diegoreymendez
approved these changes
Feb 4, 2019
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
Tested through the WPiOS PR and directly and in both scenarios this worked great. Nice job!
daniloercoli
added a commit
that referenced
this pull request
Feb 5, 2019
…rg-mobile into issue/372-move-title-to-rich-text * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Make heading styling distinguishable from paragraph (#525) Point to merged Aztec commit Setup Aztec to not autofocus when visible Refocus the last focused item after reattaching Update gutenberg ref to master Update gutenberg ref Fix some issues from merge Update gutenberg ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Move callbacks closer to Gutenberg fragment No need to specially set title/content for new post Update android bridge code after merged from develop Ability to attach ReactRootView to different Activity # Conflicts: # gutenberg
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #351
This PR updates the style of Heading block based on #351 (comment)
Changes reside in wordpress-mobile/AztecEditor-iOS#1127
WPiOS PR: wordpress-mobile/WordPress-iOS#10912 can be used for testing the main app
JS bundles are generated because we'll share a WPiOS build with @iamthomasbishop
TO TEST
1 - Testing with Example app:
yarn installyarn startyarn ios<<< Critical since it'll update Carthage dependenciesTest 1 - Create a new Heading block
Test 2 - Switch between different H sizes
Test 3 - Verify output html
<strong>tag, and other parts aren't2 - Testing with WPiOS
PR link: wordpress-mobile/WordPress-iOS#10912