Add Enter.key detection to Title block#493
Merged
daniloercoli merged 8 commits intodevelopfrom Jan 26, 2019
Merged
Conversation
Contributor
|
@daniloercoli - I'm retargetting this one as the main one was already merged. |
diegoreymendez
changed the base branch from
issue/372-add-title-to-gutenberg-mobile
to
develop
…rg-mobile into issue/372-add-enter-key-detection-to-Title-block * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Update bundle bump aztec android to v1.3.18 (#498) Update GB hash [Android] - Make sure mContentChanged has the correct value when asking content from the React side. This was necessary since the call to retrieve content and title are separate on Android. The HTML editor background is now white. Make sure to use `setContent` when initializating the GlueCode Dock the keyboard hide button to the right side of the screen (#480) RNAztecView: Removing branch spec from podspec Moving RNTAztecView.podspec to the gutenberg-mobile root dir. Aztec iOS: Force send height information to JS after pasting text # Conflicts: # gutenberg
…block" This reverts commit 9291516.
diegoreymendez
approved these changes
Jan 25, 2019
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
Nice work @daniloercoli !
…rg-mobile into issue/372-add-enter-key-detection-to-Title-block * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (51 commits) Wait for both title and content to have been set at least once before starting the RN app Update gutenberg submodule Updated gutenberg submodule Update to latest version in Gutenberg. Add info.plist properties describing the need for media access. Allow selection of media images from camera. passing serverMediaId in onMediaFileUploadSucceeded so it can be properly replaced in RN added helper method to avoid setting serverMediaId to zero everywhere where not needed or known Removed unused code Updated gutenberg submodule Updated gutenberg submodule Change media id to use a int value. Updated gutenberg submodule Implemented the callbacks for uploading the image when photo is captured with Camera changed mediaId from String to int to match media handling in Gutenberg and WP media library Update android bridge to send serverID parameter on upload event. Updated gutenberg submodule Convert the server media ID to an Int. Update bundle. Allow set of media id for media library selections. ... # Conflicts: # gutenberg
daniloercoli
deleted the
issue/372-add-enter-key-detection-to-Title-block
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new empty block when Enter.key is pressed in the Title block, and gives the ability to add a new block after it.
Note: This PR does hide the keyboard at the moment, it's a default behavior (at least) on Android., of the way we detected Enter.key. We may need to migrate the Title to RichText if there is no way to circumnavigate this problem.
Note 2: At the moment there is not split in place for the title filed. If you tap enter on the middle of the field there is no split yet.
We need to update the GB ref after the merge of the companion GB pull request here: WordPress/gutenberg#13500