Fix/upload media file media id#491
Merged
mzorz merged 2 commits intofeature/upload_media_file_androidfrom Jan 23, 2019
Merged
Conversation
… where not needed or known
…erly replaced in RN
1 task
Contributor
|
Nice work @mzorz! Thanks for the support on this one! |
marecar3
approved these changes
Jan 23, 2019
Contributor
marecar3
left a comment
marecar3
left a comment
There was a problem hiding this comment.
Looks good! Approved :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just tidies up the passing of
mediaServerId, making it clear that it's only known and used at the end of the upload, rather than passing a magic value of 0 it introduces a constant to make it more readable.Side note: we should also rename that to
serverMediaIdto actually mean what it carries, but this needs be done in coordination with iOS.