Skip to content

Upload media file ios part 2#485

Merged
SergioEstevao merged 7 commits intofeature/upload_media_file_androidfrom
feature/upload_media_file_ios_part_2
Jan 23, 2019
Merged

Upload media file ios part 2#485
SergioEstevao merged 7 commits intofeature/upload_media_file_androidfrom
feature/upload_media_file_ios_part_2

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Jan 22, 2019

This PR updates the media upload callback and events on the bridge between the native and RN.
It now allows the following:

  • setting the server media ID when the uploads finish
  • setting the server media ID when selecting a media object from the media library.

@etoledom do you want to test the implementation on iOS?
@marecar3 I did some changes on the callback that will need updates from the Android side, do you want me to change the Android part too?

@SergioEstevao SergioEstevao added this to the Beta milestone Jan 22, 2019
@SergioEstevao SergioEstevao mentioned this pull request Jan 22, 2019
Merged
1 task
etoledom
etoledom approved these changes Jan 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and looks good!

The image block adds the id on both Upload and Media library options 🎉
And now the upload finishes properly ✨

marecar3
marecar3 reviewed Jan 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why App.js and App.map files are changed in this pr @SergioEstevao ?

@marecar3
Copy link
Copy Markdown
Contributor

marecar3 commented Jan 22, 2019

I did some changes on the callback that will need updates from the Android side, do you want me to change the Android part too?

@SergioEstevao if you want, you can do it :)

@SergioEstevao
Copy link
Copy Markdown
Contributor Author

SergioEstevao commented Jan 22, 2019

not sure why App.js and App.map files are changed in this pr @SergioEstevao ?

I wanted to update the bundle to test the integration on the main apps without having Metro running.

@SergioEstevao
Copy link
Copy Markdown
Contributor Author

SergioEstevao commented Jan 22, 2019

I did some changes on the callback that will need updates from the Android side, do you want me to change the Android part too?

@SergioEstevao if you want, you can do it :)

@marecar3 I updated the Android code do you mind give it a spin?

@SergioEstevao SergioEstevao merged commit 544f68e into feature/upload_media_file_android Jan 23, 2019
@SergioEstevao SergioEstevao deleted the feature/upload_media_file_ios_part_2 branch January 23, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@marecar3 marecar3 marecar3 left review comments

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Blocks Media

Projects

None yet

Milestone

Beta

Development

Successfully merging this pull request may close these issues.

3 participants

@SergioEstevao @marecar3 @etoledom