Skip to content

Conversation

@twstokes
Copy link
Contributor

@twstokes twstokes commented Oct 12, 2021

Related PRs

Description

Fixes #4030. When rotating the Help view from portrait to landscape and back to portrait, it wasn't staying within the Safe Area boundaries.

To test: See WordPress/gutenberg#35570

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 12, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@twstokes twstokes marked this pull request as ready for review October 12, 2021 21:59
@twstokes twstokes requested a review from dcalhoun October 12, 2021 21:59
@twstokes twstokes self-assigned this Oct 12, 2021
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twstokes twstokes added the [Type] Bug Something isn't working label Oct 21, 2021
@twstokes twstokes added this to the 1.65.0 (18.6) milestone Oct 21, 2021
@twstokes twstokes merged commit 7e70349 into develop Oct 21, 2021
@twstokes twstokes deleted the fix/editor-help-safeareas branch October 21, 2021 16:34
@twstokes twstokes changed the title Wrap NavigationContainer with SafeAreaView. Add SafeAreaView to Help & Support view Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Help view does not respect notch after rotation

3 participants