Update toolbar, block and html view styling#40
Conversation
block-management/fonts.android.scss
Outdated
| /** @format */ | ||
|
|
||
| .block_code { | ||
| %monospace-font { |
There was a problem hiding this comment.
I wonder, are there any plans to expand this class with more properties? If not, can we just introduce a constant (see variables.scss for example) instead?
| "config": { | ||
| "jsfiles": "index.js app/*.js app/**/*.js block-management/*.js block-management/**/*.js store/*.js store/**/*.js", | ||
| "scssfiles": "app/*.scss app/**/*.scss block-management/*.scss block-management/**/*.scss store/*.scss store/**/*.scss" | ||
| "jsfiles": "index.js src/*.js src/**/*.js", |
There was a problem hiding this comment.
Moving mobile-related code to src/ is worth it.
|
I think there's an issue on the iOS app with the toolbar when the block is selected: Does that happen on your side @maxme ? |
|
Ouch |
sass-transformer.js
Outdated
|
|
||
| // TODO: need to find a way to pass the include paths and the default asset files via some config | ||
| const autoImportIncludePaths = [ 'gutenberg/edit-post/assets/stylesheets' ]; | ||
| const autoImportIncludePaths = [ 'src', 'gutenberg/edit-post/assets/stylesheets' ]; |
There was a problem hiding this comment.
The need to add src seems weird and I feel it's an issue withe the sass-transformer. I assume you've added this to enable the @import '../variables.scss' statement, right?
Very disappointed about that... There are some simple solutions to have a generic button-feeling for both platform, like that: Updated in 69e6717 |
Add placeholder properties for iOS AztecView.
2 participants
This PR changes:
fonts.ios.scss,fonts.android.scssthat I think will be useful later to factorize some styles.