Adds isSelected to RichText component and Paragraph, Heading blocks#237
Merged
Adds isSelected to RichText component and Paragraph, Heading blocks#237
Conversation
This was referenced Nov 14, 2018
Contributor
|
Approved the GB companion PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #113 (for RichText only)
This PR only updates the
gutenberg(PR here) andreact-native-aztec(Aztec wrapper PR) subprojects to make use of the corresponding additions ofisSelectedprop that propagates all the way down from Paragraph and Heading blocks down to RichText down to the Aztec RN wrapper to grab focus programmatically when one of these blocks get inserted.To test:
+to show the block-type pickerNOTE: the focus is handled only in Paragraph and Heading blocks in this PR (both RichText-based, which in turn is powered by Aztec). Handling for other non-RichText-based blocks will be done in a separate PR.