Merged
Conversation
Contributor
|
As a note Thank you for taking care of this! |
Tug
force-pushed
the
upgrade/react-native
branch
from
7a660cb to
3cf0917
Compare
Contributor
|
Nice :) |
Tug
force-pushed
the
upgrade/react-native
branch
2 times, most recently
from
6c8af74 to
13e67bf
Compare
gziolo
reviewed
Nov 19, 2018
| }, | ||
| ], | ||
| ], | ||
| overrides: [ |
Tug
force-pushed
the
upgrade/react-native
branch
3 times, most recently
from
00300ea to
3a9bb25
Compare
Tug
force-pushed
the
upgrade/react-native
branch
from
3a9bb25 to
45a042c
Compare
…g-bridge and upgrade react-native-windows
mzorz
reviewed
Nov 19, 2018
| "scssfiles": "src/*.scss src/**/*.scss" | ||
| }, | ||
| "engines": { | ||
| "node": ">=8.0.0 <9.0.0", |
Contributor
There was a problem hiding this comment.
can we add a comment here explaining why we're differing from Gutenberg? IDK something like
// setting version here due to following error with module sane when running node 9.x:
// error [email protected]: The engine "node" is incompatible with this module. Expected version "6.* || 8.* || >= 10.*".
// to be revisited, as we don't need to impose a limit in version per se
wdyt?
Contributor
Author
There was a problem hiding this comment.
Sadly we can't add comments to package.json, it needs to be in proper json format.
We can update the Readme or some other place
Contributor
There was a problem hiding this comment.
oh 🤦♂️ I was confused and thought we were on babel.config.js - ok updating the README 👍
mzorz
approved these changes
Nov 19, 2018
Contributor
mzorz
left a comment
mzorz
left a comment
There was a problem hiding this comment.
LGTM tested, works well after adding the node versioning tweak. Left a minor request to add a comment so people in the future understand why the node engine has been set to >=8 < 9.
Tug
force-pushed
the
upgrade/react-native
branch
from
7c20614 to
a7c4a4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires wordpress-mobile/react-native-recyclerview-list#10
Requires wordpress-mobile/react-native-aztec#74
This PR upgrades react-native to
v0.57.5as well as react tov16.6.1([email protected]'s peer dependency version).It does the necessary updates in the babel config, dependencies and submodules.
It also replaces the babel transform that was importing react automatically when JSX was found with a custom one importing the gutenberg package instead (see #184)
Testing Instructions
yarn install(Installing the required dependencies)yarn start(Starting the metro server)yarn ios(Running the app for ios)yarn android(Running the app for android)bash ./.travis/travis-checks-js.sh(Tests)