Inserter - have the RecyclerView update and re-draw item in onChange#111
Merged
mzorz merged 1 commit intofeature/inserterfrom Aug 14, 2018
Merged
Inserter - have the RecyclerView update and re-draw item in onChange#111mzorz merged 1 commit intofeature/inserterfrom
mzorz merged 1 commit intofeature/inserterfrom
Conversation
…in viewport when onChange
Contributor
|
The |
Contributor
Author
Agreed! Will try and address shortly 🙇 |
hypest
added a commit
that referenced
this pull request
Jan 18, 2019
…e-0.1.5 Bump version number to 0.1.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the change introduced in #108, the first time the RecyclerView renders its items these will all have the same height, rendering some of the blocks "cut".
BEFORE
AFTER
This PR addresses this by making sure to set these items dirty, signaling the RecyclerView to re-draw them as
onChangeis received.