Skip to content

Link added from empty link string. #703

@etoledom

Description

@etoledom

When you select some text on the paragraph block and press the Links button to add a link, the Links UI appears. If you dismiss it without adding any text to the URL filed, it will create a link with the url: http:\\

As a proposal: We shouldn't create a link if the url text is empty, but it should cancel the add-link action.

And (from @iamthomasbishop) we should consider a couple things:

  • Tapping return should probably dismiss the sheet altogether. Right now, it just hides the keyboard. If we do this, we should probably rename this ^^ button to done.

  • We should make sure the text input for URL use the URL input type/keyboard.

  • (Maybe for another ticket): We are automatically adding http:// to URLs when the user types a straight URL. If I type wordpress.org, I would expect it to stay as wordpress.org.

Reference:
#701 (comment)
#647 (comment)

bottom-sheet-keyboard-close

Metadata

Metadata

Assignees

Labels

[Type] BugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions