Fix Aztec placeholder on Gutenberg#11018
Merged
Conversation
Contributor
Author
|
@loremattei I think I broke the hash exception for Gutenberg 😥 Do you think this change is worth the trouble of updating that exception or we better leave the Podfile as it was before? Maybe there's another better trick we could use. The point is that |
Contributor
Author
|
Thank you @loremattei for the fix! 😊 |
diegoreymendez
approved these changes
Feb 18, 2019
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
Looks and works fine. Nice job!
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Gutenberg reference to test wordpress-mobile/gutenberg-mobile#591
I also took the opportunity to try to improve our gutenberg/rn-aztec Podfile integration, adding a function that modifies both at the same time. So now we just have to modify the hashes, tags, paths, branches, etc... in just one place.
To test:
rake dependencyTo test the placeholders, please refer to wordpress-mobile/gutenberg-mobile#591