Point gutenberg mobile ref to v1.1.0#9385
Conversation
Generated by 🚫 dangerJS |
mzorz
left a comment
mzorz
left a comment
There was a problem hiding this comment.
Ok, been testing this for a while, tried:
- writing
- publishing
- modifying
- updating
- turning airplane mode on/off
- rotating.
- opening a large GB post.
- uploading media in various ways
All of this seems to be generally working 👍
I can see the title height change on my phone although it's minor (not abrupt as it was before the fix).
I had a crash once, when opening a post with an image block I had just uploaded, and rotating the device while the Editor loader spinner was being shown (https://gist.github.com/mzorz/10a4e975ad130141437d485051227ab2). It happened only after switching back to classic on long posts, and it was an OOM that I couldn't really reproduce without doing the Aztec dance so, I'll give it the go.
I noticed that opening a post with any content, then rotating the device, will produce a new action in the undo/redo history. Opened an issue with that wordpress-mobile/gutenberg-mobile#727, as it's not a blocker for this PR.
LGTM 
|
Thanks @mzorz ! |
|
Re-tested after the hash was updated, all looks good here @marecar3 ! |
2 participants
This PR updates the gutenberg-mobile reference to point to the latest release, v1.1.0. No wpandroid integration changes introduced.
The reference is currently pointing to the
release/1.1.0branch on https://github.com/wordpress-mobile/gutenberg-mobile. Relevant PR: [https://github.com/wordpress-mobile/gutenberg-mobile/pull/726).When that gets merged to gutenberg-mobile master, I'll update the ref here to point to the merge commit.
To test:
The block editor should work as normal.
Update release notes:
RELEASE-NOTES.txt.