Skip to content

Conversation

@geriux
Copy link
Contributor

@geriux geriux commented Jun 3, 2024

Fixes #


To Test:


Regression Notes

  1. Potential unintended areas of impact

    • TODO
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • TODO
  3. What automated tests I added (or what prevented me from doing so)

    • TODO

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@geriux geriux added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Jun 3, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused some dependency changes (expand to see details)

 \--- project :libs:editor
-     \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.120.0-alpha1
-          +--- com.facebook.fresco:animated-gif:2.0.0
-          |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.5 (*)
-          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 3.1.3 (*)
-          |    \--- com.facebook.fresco:animated-base:2.0.0
-          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 3.1.3 (*)
-          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 3.1.3 (*)
-          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 3.1.3 (*)
-          |         +--- com.facebook.fresco:animated-drawable:2.0.0
-          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 3.1.3 (*)
-          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 3.1.3 (*)
-          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 3.1.3 (*)
-          |         \--- com.parse.bolts:bolts-tasks:1.4.0
-          +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-7
-          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    |    \--- com.google.guava:guava:27.1-android
-          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-          |    |         \--- androidx.media:media:1.2.1 (*)
-          |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
-          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.12.0 (*)
-          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.12.0 (*)
-          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-5
-          +--- org.wordpress.react-native-libraries.v6:react-native-get-random-values:1.4.0
-          +--- org.wordpress.react-native-libraries.v6:react-native-safe-area-context:4.8.2
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
-          +--- org.wordpress.react-native-libraries.v6:react-native-screens:3.29.0
-          |    +--- androidx.appcompat:appcompat:1.6.1 (*)
-          |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.2.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
-          |    +--- com.google.android.material:material:1.9.0 (*)
-          |    +--- androidx.core:core-ktx:1.9.0 -> 1.12.0 (*)
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-          |    \--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1 -> 2.6.2 (c)
-          +--- org.wordpress.react-native-libraries.v6:react-native-svg:14.0.0
-          +--- org.wordpress.react-native-libraries.v6:react-native-webview:13.6.1
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
-          |    \--- androidx.webkit:webkit:1.4.0 -> 1.10.0 (*)
-          +--- org.wordpress.react-native-libraries.v6:react-native-masked-view:0.3.0
-          +--- org.wordpress.react-native-libraries.v6:react-native-clipboard:1.11.2
-          +--- org.wordpress.react-native-libraries.v6:react-native-fast-image:8.5.11
-          |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0
-          |    |    +--- com.github.bumptech.glide:gifdecoder:4.16.0
-          |    |    |    \--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
-          |    |    +--- com.github.bumptech.glide:disklrucache:4.16.0
-          |    |    +--- com.github.bumptech.glide:annotations:4.16.0
-          |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-          |    |    +--- androidx.exifinterface:exifinterface:1.3.6 (*)
-          |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
-          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-          |         +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0 (*)
-          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.12.0 (*)
-          |         \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-          +--- org.wordpress.react-native-libraries.v6:react-native-reanimated:3.6.2
-          |    +--- com.facebook.yoga:proguard-annotations:1.19.0
-          |    +--- androidx.transition:transition:1.1.0 -> 1.4.1 (*)
-          |    \--- androidx.core:core:1.9.0 -> 1.12.0 (*)
-          +--- org.wordpress.react-native-libraries.v6:react-native-gesture-handler:2.14.1
-          |    +--- org.wordpress.react-native-libraries.v6:react-native-reanimated:3.6.2 (*)
-          |    +--- androidx.appcompat:appcompat:1.6.1 (*)
-          |    +--- androidx.core:core-ktx:1.9.0 -> 1.12.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
-          +--- org.wordpress.react-native-libraries.v6:react-native-linear-gradient:2.7.3
-          +--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.120.0-alpha1
-          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-          |    +--- androidx.gridlayout:gridlayout:1.0.0
-          |    |    +--- androidx.core:core:1.0.0 -> 1.12.0 (*)
-          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-          |    +--- androidx.cardview:cardview:1.0.0 (*)
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
-          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-          |    +--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
-          |    +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 -> v2.1.3 (*)
-          |    +--- org.wordpress.aztec:wordpress-comments:v2.1.2 -> v2.1.3 (*)
-          |    +--- org.wordpress.aztec:glide-loader:v2.1.2
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-          |    |    +--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
-          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
-          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+     \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:6903-82833d02f3e133cb314239bfbe117d3bb6b0a84a
+          +--- com.facebook.fresco:animated-gif:2.0.0
+          |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.5 (*)
+          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 3.1.3 (*)
+          |    \--- com.facebook.fresco:animated-base:2.0.0
+          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 3.1.3 (*)
+          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 3.1.3 (*)
+          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 3.1.3 (*)
+          |         +--- com.facebook.fresco:animated-drawable:2.0.0
+          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 3.1.3 (*)
+          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 3.1.3 (*)
+          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 3.1.3 (*)
+          |         \--- com.parse.bolts:bolts-tasks:1.4.0
+          +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
+          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-7
+          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    |    \--- com.google.guava:guava:27.1-android
+          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+          |    |         \--- androidx.media:media:1.2.1 (*)
+          |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
+          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.12.0 (*)
+          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.12.0 (*)
+          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-5
+          +--- org.wordpress.react-native-libraries.v6:react-native-get-random-values:1.4.0
+          +--- org.wordpress.react-native-libraries.v6:react-native-safe-area-context:4.8.2
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+          +--- org.wordpress.react-native-libraries.v6:react-native-screens:3.29.0
+          |    +--- androidx.appcompat:appcompat:1.6.1 (*)
+          |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.2.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
+          |    +--- com.google.android.material:material:1.9.0 (*)
+          |    +--- androidx.core:core-ktx:1.9.0 -> 1.12.0 (*)
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+          |    \--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1 -> 2.6.2 (c)
+          +--- org.wordpress.react-native-libraries.v6:react-native-svg:14.0.0
+          +--- org.wordpress.react-native-libraries.v6:react-native-webview:13.6.1
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+          |    \--- androidx.webkit:webkit:1.4.0 -> 1.10.0 (*)
+          +--- org.wordpress.react-native-libraries.v6:react-native-masked-view:0.3.0
+          +--- org.wordpress.react-native-libraries.v6:react-native-clipboard:1.11.2
+          +--- org.wordpress.react-native-libraries.v6:react-native-fast-image:8.5.11
+          |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0
+          |    |    +--- com.github.bumptech.glide:gifdecoder:4.16.0
+          |    |    |    \--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
+          |    |    +--- com.github.bumptech.glide:disklrucache:4.16.0
+          |    |    +--- com.github.bumptech.glide:annotations:4.16.0
+          |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+          |    |    +--- androidx.exifinterface:exifinterface:1.3.6 (*)
+          |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
+          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+          |         +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0 (*)
+          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.12.0 (*)
+          |         \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+          +--- org.wordpress.react-native-libraries.v6:react-native-reanimated:3.6.2
+          |    +--- com.facebook.yoga:proguard-annotations:1.19.0
+          |    +--- androidx.transition:transition:1.1.0 -> 1.4.1 (*)
+          |    \--- androidx.core:core:1.9.0 -> 1.12.0 (*)
+          +--- org.wordpress.react-native-libraries.v6:react-native-gesture-handler:2.14.1
+          |    +--- org.wordpress.react-native-libraries.v6:react-native-reanimated:3.6.2 (*)
+          |    +--- androidx.appcompat:appcompat:1.6.1 (*)
+          |    +--- androidx.core:core-ktx:1.9.0 -> 1.12.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+          +--- org.wordpress.react-native-libraries.v6:react-native-linear-gradient:2.7.3
+          +--- org.wordpress.gutenberg-mobile:react-native-aztec:6903-82833d02f3e133cb314239bfbe117d3bb6b0a84a
+          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+          |    +--- androidx.gridlayout:gridlayout:1.0.0
+          |    |    +--- androidx.core:core:1.0.0 -> 1.12.0 (*)
+          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+          |    +--- androidx.cardview:cardview:1.0.0 (*)
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
+          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+          |    +--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
+          |    +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 -> v2.1.3 (*)
+          |    +--- org.wordpress.aztec:wordpress-comments:v2.1.2 -> v2.1.3 (*)
+          |    +--- org.wordpress.aztec:glide-loader:v2.1.2
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+          |    |    +--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
+          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20929-a22702f
Commita22702f
Direct Downloadjetpack-prototype-build-pr20929-a22702f.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20929-a22702f
Commita22702f
Direct Downloadwordpress-prototype-build-pr20929-a22702f.apk
Note: Google Login is not supported on these builds.

@geriux geriux closed this Jun 4, 2024
@geriux geriux deleted the gutenberg/test-image-bug branch June 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants